I smoke and also drink lots of coffee. I drink a lot of things like cranberry and blueberry juice also. These things really stain my teeth badly. I have tried a lot of whitening toothpastes. They all work "ok", but nothing to write home about. I decided to try Colgate Visible White toothpaste because if was on sale one time. I was very happily surprised to see that it seemed to really work better than the others. I use an electric toothbrush and the Colgate and it really works great. I can tell if I don't use it one day, my teeth will start staining up right away. I find that it isn't abrasive and it makes my mouth feel really clean and fresh also. I did end up getting a tube of something else as a sample in the mail. I had run out of Colgate so I went ahead and used it. Wow, what a difference. I will stick with my Colgate Visible White to keep my teeth looking great all the time.